Hello Alberto,
On Fri, Jan 29, 2010 at 10:18:46PM +0100, Alberto Panizzo wrote:
> The MXC family of Application Processors is shipped with a Keypad Port
would you mind to do s/MXC/IMX/ in your patch? Currently both are used
but we (=Sascha and me) will try to deprecate MXC.
> + * >>Power management need to be implemented<<.
s/need/needs/ (or alternatively do it :-) and maybe s/<<\./.<</ ?
> [...]
> +
> + /* The matrix is stable only if no changes are detected after
> + * MXC_KEYPAD_SCANS_FOR_STABILITY scans */
unusual format of the comment.
/*
* ...
* ...
*/
is the most found way in the kernel for multi-line comments.
> [...]
> +MODULE_LICENSE("GPL v2");
There is no space expected in the string passed to MODULE_LICENSE.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
