On Mon, Sep 7, 2009 at 10:14 PM, Kyungmin Park<kmpark@xxxxxxxxxxxxx> wrote: > On Mon, Sep 7, 2009 at 9:38 PM, Jinsung Yang<jsgood.yang@xxxxxxxxxxx> wrote: >>> > I have some questions: >>> > 1) Could you explain to us what is the 'well-defined' driver? >>> >>> I mean the driver to support three cpu and various target in one keypad >>> driver, but i think that your posted driver seems for only SMDK6410. >>> Also, we can make better driver via the review. >>> >> >> Why do you think my driver cannot support various target? >> I think there are misunderstandings, are there any architecture specific codes? >> Surely, there can be something wrong driver-specific codes such as 'dev_pm_ops', >> but that's not a big deal.. we can modify it with mainline feedbacks. >> My driver codes also have considered for our s5pc100, s5pc110, and many Samsung SoCs. >> We will support other SoCs with adding some architecture definitions (not changing driver codes), but just 'NOT NOW'. >> Please understand, 'step by step'. >> Of course we aware now our SoCs line-ups better than you, we are not happy to hear from you. >> >> Finally, in your driver, regarding the if (cpu_is_s5pc100()) statement, >> how do you think if you have to check another SoC at some time in the future? >> Doing like this if (cpu_is_s5pc110()) else if (cpu_is_s5pc120()) else if (cpu_is_s5pc130()) ?? >> Will you send some patches for this? looks be not good. > > Then question. If next new chips has different field but has same > offset or address. In this case how you handle it? > E.g., How to use handle s5pc100 and s5pc110 simultaneously at one > driver without re-compile? Just FYI: please see the other arch, OMAP. and how to use it. http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=blob;f=arch/arm/plat-omap/include/mach/cpu.h;h=7a5f9e882e54b140d87b1a4648f130366c102f69;hb=HEAD Thank you, Kyungmin Park -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
