Hi, On 9/7/2009 8:32 PM, Jinsung Yang wrote: > Hi, Mr.Shim > >>> submitted mainline. This is what Jinsun was starting, and which he >>> will continue until it is included mainline. >>> >> The keypad of s3c64xx and s5pc1xx is same almost, so we need to submit >> the well-defined driver from the first. > > I have some questions: > 1) Could you explain to us what is the 'well-defined' driver? I mean the driver to support three cpu and various target in one keypad driver, but i think that your posted driver seems for only SMDK6410. Also, we can make better driver via the review. > 2) Did you test your keypad driver at s3c6410 based platform? No, i cannot test it on s3c64xx because i don't have a target using the keypad of s3c64xx such SMDK6410 but i tested the keypad driver on s5pc100 and s5pc110 and as you know, the keypad of the s3c6410 and s5pc100 datasheet is same almost, so i think it will operate on s3c64xx. > 3) There is no architecture codes for s5pc1xx series, why did you send keypad driver first for s5pc1xx before architecture codes? > Of course, I can post the arch code for keypad, but it is the common code for s3c64xx and s5pc1xx and we didn't post s5pc1xx arch code yet on ML. I also think it is better to post the keypad driver after posting arch. > Best Regards > -- > Jinsung, Yang <jsgood.yang@xxxxxxxxxxx> > AP Development Team > System LSI, Semiconductor Business > SAMSUNG Electronics Co., LTD > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
