On Monday 31 August 2009, Barry Song wrote: > --- /dev/null > +++ b/include/linux/spi/ad714x.h Doesn't belong under SPI since this is also used by the I2C version of the chip. Likely include/linux/input/*h is best. > @@ -0,0 +1,60 @@ > +/* > + * include/linux/ad714x.h Never include the directories. And the coding style says this should have a twitter-sized description of the driver in that line, like * ad714x.h -- platform data for capacitance sensor driver It's good policy to include a brief GPL statement at the top of every source file too, including a Copyright (C) you. > + * > + * AD714x is very flexible, it can be used as buttons, scrollwheel, > + * slider, touchpad at the same time. That depends on the boards. > + * The platform_data for the device's "struct device" holds this > + * information. > + */ > + > + > +#ifndef AD714X_HW_H > +#define AD714X_HW_H As noted: __LINUX_INPUT_AD714X_H is the style to use here. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
