On Tuesday 01 September 2009, Mike Frysinger wrote: > > + ret = request_threaded_irq(ad714x->bus->irq, ad714x_interrupt, > > + ad714x_interrupt_thread, IRQF_TRIGGER_FALLING, > > + "ad714x_captouch", ad714x); IRQF_SHARED is worth including; and TRIGGER_FALLING is not good to hard-wire, maybe it gets inverted or hooked up to an IRQ controller which only supports level triggers. Best to have the trigger mode come from the platform data. Of course, if it's a level triggered IRQ then it clearly can't be IRQF_SHARED since someone will need to mask it off at the IRQ controller before exiting the hardirq handler, and unmask it before exiting the threaded handler. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
