On Sat, Aug 01, 2009 at 01:52:22PM -0700, Marcel Holtmann wrote: > actually if the key is clearly hardwired to WLAN, then it should not > even show up as input event at all. This is one of the mis-concepts of > the old RFKILL subsystem. No need to send an input event if the platform > driver is going to rfkill that device anyway. There's still a policy decision. Does it kill internal devices, or does it kill all attached wlan devices? > Remember that in the end it is just a key and whatever the user does > with it is users policy. So in summary it is up to the platform driver > to emit the proper key. For some it might be still KEY_WLAN, for other > it might be KEY_RFKILL. Sounds fair? I agree on the technical side, but not the naming. KEY_WLAN is an rfkill-related key, so introducing KEY_RFKILL is potentially confusing. KEY_RFKILL_ALL isn't. -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
