On Sat, Aug 01, 2009 at 01:38:53PM -0700, Marcel Holtmann wrote: > actually I would prefer if we name this key KEY_RFKILL and not put the > policy of ALL into the kernel. Since we wanna get rid of rfkill-input. > That needs to be done in userspace and by users policy. If they wanna > map that key to ALL then that is fine. If they just wanna toggle WiFi, > then that is also fine. If the wanna have to popup some UI, that is also > reasonable. My reasoning was that this conceptually maps to a key that controls all of the radios in the system - whether a single press actually kills all of them or not is kind of irrelevent (having the simple policy in rfkill-input works fine for this, but userspace will obviously want something more cunning). My concern with KEY_RFKILL is that it it's not obvious that it refers to a specific type of key - ones that purely control wifi should still be KEY_WLAN, for instance. -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
