Hi! > >> disable_irq_nosync or convert this to request_threaded_irq(...). > >> Please see recent discussion on linux-input for MAX key switch > >> controller. > > > > Do you have a link? (I replaced it with disable_irq_nosync, if that is > > enough...) > > > > link: http://patchwork.kernel.org/patch/35515/ Thanks! > >> > + if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) { > >> > >> check for SMBUS? I have added linux-i2c as this driver has i2c bits, > >> so not removing any code. > > > > I guess this driver is only probed on mach-pxa... on machines that > > have the neccessary hardware. > > Because this driver is using smbus i2c apis, it will be good to add > that check too. So I should do something like if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_WORD_DATA)) ... in addition? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
