On Wed, Jun 03, 2009 at 11:01:21AM +0100, Mark Brown wrote: > On Wed, Jun 03, 2009 at 02:45:15PM +0900, Joonyoung Shim wrote: > > If request_irq() fails, we have to return -EBUSY instead of -EINVAL. > > Could you provide a bit more explanation for this one, please? -EBUSY > seems to give entirely the wrong impression to applications since in the > systems where this driver will be deployed a failure to acquire the IRQ > is most likely to be due to incorrect platform data and it is highly > unlikely to resolve itself. The "most correct" thing would be to propagate the value returned by request_irq() I think but since nobidy actually uses result of wm97xx_init_pen_irq() I just would not bother at all. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
