On Wed, Jun 03, 2009 at 07:19:14AM -0700, Dmitry Torokhov wrote: > The "most correct" thing would be to propagate the value returned by > request_irq() I think but since nobidy actually uses result of > wm97xx_init_pen_irq() I just would not bother at all. Yeah, I was looking at that - the driver can run in polling mode so it's fine as-is. I could change the code to return void, I suppose. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html