Re: [PATCH] hid: add force feedback support for SmartJoy PLUS PS2/USB adapter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting "Oliver Neukum" <oliver@xxxxxxxxxx>:

Am Freitag, 8. Mai 2009 09:46:36 schrieb Jussi Kivilinna:
+static int sj_probe(struct hid_device *hdev, const struct hid_device_id
*id) +{
+       int ret;
+
+       ret = hid_parse(hdev);
+       if (ret) {
+               dev_err(&hdev->dev, "parse failed\n");
+               goto err;
+       }
+
+       ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT & ~HID_CONNECT_FF);
+       if (ret) {
+               dev_err(&hdev->dev, "hw start failed\n");
+               goto err;
+       }
+
+       sjoyff_init(hdev);

Do you really want to ignore errors this returns?

	Regards
		Oliver


It's done same in hid-pl.c & hid-gaff.c which I used base for this driver. I'd say yes, ignoring return sjoyff_init is ok. If ff-setup fails adapter will still be usable (but without ff). This is actually what happened when I tried this driver with other Wisegroup adapter.

-Jussi

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux