On Mon, Mar 02, 2009 at 02:44:28PM +0100, Jiri Slaby wrote:
> On 2.3.2009 14:23, Mark Brown wrote:
>> +static int pressure;
>> +module_param(pressure, int, 1);
> Weird permissions.
Fixed.
>> + int count = 16;
>> + schedule_timeout_uninterruptible(1);
> You meant ssleep(1)?
msleep, but yes. Shows how old the code is - I'll update.
>> +
>> + while (count< 16) {
> Weird condition.
> + conding style
Hrm. This appears to have been mangled somewhere in the mail path to
you - the indentation is normal in my send-mail folder and in the copy I
got back from the list.
>> + if (tries> 5) {
> Where is tries defined?
Further up the file as a global static. I've pulled the variables into
the function since it's the only place they're used.
>> +static int wm97xx_acc_startup(struct wm97xx *wm)
>> +{
>> + int idx = 0;
> No need to initialize.
Fixed.
>> +static void wm97xx_irq_enable(struct wm97xx *wm, int enable)
>> +{
>> + if (enable)
>> + enable_irq(wm->pen_irq);
>> + else
>> + disable_irq(wm->pen_irq);
> sync?
Could you expand on this, please?
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
