Re: [PATCH 1/2] Input: Accelerated touchscreen support for Marvell Zylonite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2.3.2009 14:23, Mark Brown wrote:
index 0000000..b016021
--- /dev/null
+++ b/drivers/input/touchscreen/zylonite-wm97xx.c
[...]
+/*
+ * Pressure readback.
+ *
+ * Set to 1 to read back pen down pressure
+ */
+static int pressure;
+module_param(pressure, int, 1);

Weird permissions.

+/* flush AC97 slot 5 FIFO machines */
+static void wm97xx_acc_pen_up(struct wm97xx *wm)
+{
+	int count = 16;
+	schedule_timeout_uninterruptible(1);

You meant ssleep(1)?

+
+	while (count<  16) {

Weird condition.
+ conding style

+		MODR;
+		count--;
+	}
+}
+
+static int wm97xx_acc_pen_down(struct wm97xx *wm)
+{
+	u16 x, y, p = 0x100 | WM97XX_ADCSEL_PRES;
+	int reads = 0;
+
+	/* When the AC97 queue has been drained we need to allow time
+	 * to buffer up samples otherwise we end up spinning polling
+	 * for samples.  The controller can't have a suitably low
+	 * threashold set to use the notifications it gives.
+	 */
+	schedule_timeout_uninterruptible(1);

ssleep

+	if (tries>  5) {

Where is tries defined?

+static int wm97xx_acc_startup(struct wm97xx *wm)
+{
+	int idx = 0;

No need to initialize.

+static void wm97xx_irq_enable(struct wm97xx *wm, int enable)
+{
+	if (enable)
+		enable_irq(wm->pen_irq);
+	else
+		disable_irq(wm->pen_irq);

sync?
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux