Re: [PATCH] input: input: stop autorepeat timer on key release

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2009-01-12 at 21:02 -0800, Dmitry Torokhov wrote:

> > > This introduces a slight change in behaviour (the key that is released
> > > may not be one that is being autorepeated) but I think it still makes
> > > sense to do it.
> > 
> > Hmm, good point, I thought it didn't, but it does when you press a, b
> > wait, release a then b doesn't continue autorepeating. Seems like a
> > corner case though, so I agree. We could fix that by checking which key
> > is being autorepeated though, I'd think, see below (untested as of now)
> > 
> 
> I actually think the original change was better - sometimes when shift or
> alt or ctrl key gets stuck it takes time to figure out what happened. If
> we stop autorepeat upon release of any key it will recover much quicker.

Heh, good point too. Well, I was just confused by seeing the timer in
there until I realised what was going on, so feel free to take either
patch. :)

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux