Re: [patch]fix memleak in error case of hiddev

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/12/2008 03:55 PM, Oliver Neukum wrote:
> Am Mittwoch, 12. November 2008 15:48:38 schrieb Jiri Kosina:
>> +	if (!list->hiddev->open++) {
>> +		if (list->hiddev->exist) {
> 
> The order of checks is inverted. If the device no longer exists
> opening should fail, even if the device is already opened.
> Didn't I post a patch that does this? My memory is a bit clouded.

This is very old (and broken) version of the patch. I remember I already
commented some issues contained in this one and you did fix them later ;).
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux