Re: [patch]fix memleak in error case of hiddev

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 12 Nov 2008, Oliver Neukum wrote:

> > +	if (!list->hiddev->open++) {
> > +		if (list->hiddev->exist) {
> The order of checks is inverted. If the device no longer exists opening 
> should fail, even if the device is already opened. 

Right.

> Didn't I post a patch that does this? My memory is a bit clouded.

I don't seem to have it, but I have been buried in hundreds of pending 
e-mails after coming back from vacation. So if you have it handy with 
changelog and Signed-off-by, I'd appreciate if you resend it to me. 
Otherwise I'll dig for it a little bit harder.

Thanks,

-- 
Jiri Kosina
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux