Dmitry Torokhov wrote: > On Sun, Jul 20, 2008 at 05:10:21PM +0300, Anssi Hannula wrote: >> Ping? Please comment :) I'd really much like the hid-pidff driver >> to not panic when used. >> >> For the record, here is a workqueue solution. It is much less >> intrusive than the previous patch, but IMO less correct. >> > > I was deferring the final judgement to Jiri but I like the generic > solution with com plete copy of the report best of all. I also wonder if > we could pre-allocate the buffer for the report queue so we dont need to > allocate it separately for each request. It would take (biggest report of the hid device)*64 bytes for output fifo and (biggest report of the hid device)*256 bytes for control fifo. Maximum report size is 4096 bytes, though I guess most devices' biggest report is far shorter than that. I'll leave it up to you people. I'll be away (military service) for the next 2 weeks, but after that I can do some quick testing on any suggested patch on my next short vacation. -- Anssi Hannula -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
