On Mon, Apr 14, 2008 at 02:10:02PM -0400, Dmitry Torokhov wrote: > On Mon, Apr 14, 2008 at 06:39:33PM +0100, Mark Brown wrote: > > + if (!work_pending(&wm->pen_event_work)) { > > + wm->mach_ops->irq_enable(wm, 0); > > + queue_work(wm->ts_workq, &wm->pen_event_work); > > + } > Given the fact that work will not be queued if it is pending anyway > why is this change needed? As well as not queuing the work it ensures that the calls to irq_enable() are balanced which helps with implementing that operation. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html