----- Original Message ----- > From: "Harald Hoyer" <harald@xxxxxxxxxx> > To: "Liu ping fan" <kernelfans@xxxxxxxxx>, "Pingfan Liu" <piliu@xxxxxxxxxx> > Cc: initramfs@xxxxxxxxxxxxxxx > Sent: Wednesday, June 21, 2017 10:41:50 PM > Subject: Re: [PATCH] modules.d: introduce ssh-server module to provide service > > On 12.06.2017 07:47, Liu ping fan wrote: > > Hi Harald, what is your opinion of such functionality? > > yeah, nice, but some issues: > > 1) "inst" should be used instead of "inst_simple" for executables and *.so > 2) That is a long hardcoded list of dependencies. Are they all needed? > 3) The module should probably be renamed to rhel-7-ssh-server or a similar > name > to reflect, that it is most likely only working on this distribution > variant > 4) Does it have to be shipped in upstream dracut? Looks like this can live > totally > fine in a project, which lives outside of dracut. > Ah, I brought up this patch to ease the remote debugging on customer env. And usually the bug reporter is not familiar with detail, and it cost some time to communicate. With this patch, it is more easy to debug the initrd issue with capture-kernel. It is ok if you think it is better to keep this patch lives outside of dracut. I can ask the customer to install it by manual. Thanks and regards, Pingfan -- To unsubscribe from this list: send the line "unsubscribe initramfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
