----- Original Message ----- > From: "Daniel Molkentin" <dmolkentin@xxxxxxx> > To: "Harald Hoyer" <harald@xxxxxxxxxx>, "Liu ping fan" <kernelfans@xxxxxxxxx>, "Pingfan Liu" <piliu@xxxxxxxxxx> > Cc: initramfs@xxxxxxxxxxxxxxx > Sent: Wednesday, June 21, 2017 11:14:21 PM > Subject: Re: [PATCH] modules.d: introduce ssh-server module to provide service > > On 06/21/2017 04:41 PM, Harald Hoyer wrote: > > On 12.06.2017 07:47, Liu ping fan wrote: > >> Hi Harald, what is your opinion of such functionality? > > yeah, nice, but some issues: > > > > 1) "inst" should be used instead of "inst_simple" for executables and *.so > > 2) That is a long hardcoded list of dependencies. Are they all needed? > > 3) The module should probably be renamed to rhel-7-ssh-server or a similar > > name > > to reflect, that it is most likely only working on this distribution > > variant > > 4) Does it have to be shipped in upstream dracut? Looks like this can live > > totally > > fine in a project, which lives outside of dracut. > I was about to introduce something similar, I would try to keep it > general purpose. A good use case could be to unlock an encrypted root fs > after a reboot, even though that would require more work. > Yeah, I notice that project. It is great, but it is a pity that it is not merged into drauct upstream since it is a little complicated and difficult to maintain. > Some things I noticed: > > 1. This should go into modules.d, not the root > 2. check() should return 255 even if sshd is found (you probably don't > want this to be the default)? > 3. the multiple inst_simples for the different keys seem excessive, plus > there might be more than those. Use a glob? > Yes. Thank you for advice. Best regards, Pingfan > Cheers, > Daniel > > -- > To unsubscribe from this list: send the line "unsubscribe initramfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe initramfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
