On 07/31/2013 04:20 PM, Vivek Goyal wrote: > On Wed, Jul 31, 2013 at 04:07:16PM +0200, Harald Hoyer wrote: >> On 07/23/2013 12:16 PM, Baoquan He wrote: >>> Currently when action_on_fail is enabled, the emergency_shell won't be called. >>> In kdump even though user specify the default action as emergency_shell, >>> dracut skip it. Now change the implementation of action_on_fail to depend >>> on a file which is created by kdump when making kdump initrd, then remove it >>> at the beginning of kdump. This can solve the explicit emergency_shell problem. >>> >>> And action_on_fail won't need paramenters, remove the relevant description in >>> dracut man page. >> >> I like it. >> >> Vivek: would that solve one of your systemd problems? > > Hi Harald, > > Yes this should solve one of the problems of being able to call emergency > shell from kdump module. > > I was thinking of modirying emergency.service on the fly and then reload > systemd config. But I guess this solution is simpler. > > It also takes away the flexibility of being able to specify "reboot" or > some other actions as failure actions. But nobody as asked for those > yet. > > So yes, agreed, this will solve atleast one problem. So makes sense > to take it in. > > Thanks > Vivek > pushed, thanks! -- To unsubscribe from this list: send the line "unsubscribe initramfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
