Re: [PATCH] ifcfg: write DNS1=... for nameserver= args (RHBZ#815369)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2012-04-24 at 12:45 +0200, Harald Hoyer wrote:

> Hmm, I have this in my queue (different location):
>
> diff --git a/modules.d/45ifcfg/write-ifcfg.sh b/modules.d/45ifcfg/write-ifcfg.sh
> index c072a13..b81ac39 100755
> --- a/modules.d/45ifcfg/write-ifcfg.sh
> +++ b/modules.d/45ifcfg/write-ifcfg.sh
> @@ -138,6 +138,11 @@ for netif in $IFACES ; do
>              } >> /tmp/ifcfg/ifcfg-$ethname
>          fi
>      fi
> +    i=1
> +    for ns in $(getargs nameserver); do
> +        echo "DNS${i}=${ns}" >> /tmp/ifcfg/ifcfg-$netif
> +        i=$((i+1))
> +    done
>  done
> 
>  # Pass network opts

The code is actually equivalent, although I find this version confusing
since it comes after all the other special cases (I thought it was part
of the 'if [ -n "$bridge" ]' block at first!)

I'm sending an amended patch that puts it right next to all the other
unconditional stuff near the top of the loop - I think that's clearest.

-w

--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux