Re: [PATCH 1/2 v2] split nfsroot rpc start code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/01/2012 04:16 PM, Dave Young wrote:
On 02/01/2012 04:04 PM, Cong Wang wrote:

On 02/01/2012 04:00 PM, Dave Young wrote:
On 02/01/2012 03:56 PM, Cong Wang wrote:

On 02/01/2012 03:56 PM, Dave Young wrote:
On 02/01/2012 03:48 PM, Cong Wang wrote:
On Wed, 01 Feb 2012 at 02:00 GMT, Dave Young<dyoung@xxxxxxxxxx>
wrote:
Index: dracut/modules.d/95nfs/module-setup.sh
===================================================================
--- dracut.orig/modules.d/95nfs/module-setup.sh
+++ dracut/modules.d/95nfs/module-setup.sh
@@ -57,6 +57,7 @@ install() {
        dracut_install $(for _i in $(ls {/usr,}$libdir/libnss*.so
2>/dev/null); do echo $_i;done | egrep "$_nsslibs")

        inst_hook cmdline 90 "$moddir/parse-nfsroot.sh"
+    inst_hook cmdline 91 "$moddir/nfs-start-rpc.sh"

I am sure this is wrong. You need pre-pivot.


I want to start them as early as we can, I always think about user use
dracut as a minimal recovery system, they need do something manually.


Then install it as pre-pivot 00.


What if I use rdbreak=point which is before pre-pivot?


Take a look at all existing cmdline hooks, all of them handle cmdline,
but nfs-start-rpc doesn't, so not cmdline hook please. You are abusing
cmdline hooks.



Maybe current cmdline hooks all deal with cmdline things, but as my
understand cmdline hook point is just a point for injecting anything we
need to handle at this point.

If you think pre-pivot is too late, then try other hooks, e.g. pre-mount, pre-udev. Anyhow, cmdline is definitely not the place.

--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux