On Mon, Dec 26, 2011 at 9:57 AM, Dave Young <dyoung@xxxxxxxxxx> wrote: > On 12/25/2011 07:49 PM, Cong Wang wrote: > >> On Fri, 23 Dec 2011 at 08:04 GMT, Dave Young <dyoung@xxxxxxxxxx> wrote: >>> ssh module will need root user in /etc/passwd, so add root and nobody >>> to /etc/passwd in 99base instead of nfs module >> >> Huh? Even for who don't use either ssh module or nfs module?? >> >> I think you just need to copy these two lines into your ssh module... > > > Thanks for your review. > > in 90mdraid module there's words in its comments about passwd, so there > might be more modules need passwd. But there are still more modules that don't need passwd, right? > > Dealing with same thing in multi module is not good, not only duplicate > code, but also they could cause conflict. Ie. nfs set root home dir to / > but we need /root, if nfs module added after ssh-client the home dir of > root will be /. If you don't want to duplicate the code, make it a function (maybe in dracut-function?), putting it in base module is confusing. -- To unsubscribe from this list: send the line "unsubscribe initramfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
