Re: [RFC PATCH] Move actually mounting the root filesystem into its own series of hooks.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Thiago Galesi wrote:
Warren Togami wrote:
A question: Why not use root=/dev/nfs and the other options according to
kernel doc, like nfsroot=... and ip=autoconf? For me that is much more
readable.
It is a matter of taste and historical contingency, I suppose.  The
current nfsroot mounting stuff was added way before initramfs/initrd was
an option, and it was probably easier to not mess up the in-kernel root=
handling code (which expected a device to mount).


I think it is important to keep backwards compatibility in this
specific case, and handle "root=/dev/nfs" kind of stuff. Really, think
about keeping 2, 3 different cmdlines depending if the system is newer
or older. It may look like a small hassle, but getting this right
sometimes takes some time

Suggestion: Since all hook scripts are sourced, why not put the option parsing stuff inside pre-mount, setting global variables the mount scripts can depend on? That way we can handle any option passing we want, even through dhcp options.

Regards,
Philippe

--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux