Re: [PATCH 01/31] Some dracut cleanups and bashification.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Feb 9, 2009, at 11:15 AM, Dave Jones <davej@xxxxxxxxxx> wrote:

On Sun, Feb 08, 2009 at 04:34:41PM -0800, Victor Lowther wrote:
Hi, I enjoy hacking on system infrastructure and am a bash programming aficionado. With that in mind, I present this patch series against current master -- it simplifies several bits of code and shaves about 200 lines out of the codebase. The final result has been tested on a Fedora 10 box that uses lvm on top of dm-crypt, and it works fine. I have not tested all
intermediate steps -- life is too short.

The introduction of additional bashisms is something I'm not sold on.

Well, it seems that most of the concern about bashisms has to do with the code that ends up on the initrd. Making that code strictly posix is probably a good thing.

There is no real benifit in having the initrd generating code be strictly posix, IMHO. It could be written in C, python, haskell, or INTERCAL.

Others have already expressed concern over what we have already,
so I think making it unnecessarily harder to switch to an alternative
shell may not be the best plan, especially when the benefits aren't
really that great.

Yeah, having the bits that end up in the initrd be posix is a good design constraint.

Thanks for taking the time to get involved though, it's good to see
people actually playing with the code.

Indeed.


   Dave

--
http://www.codemonkey.org.uk
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux