Re: [PATCH 1/3] dt-bindings: iio: light: veml6046x00: add color sensor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 17/03/2025 12:17, Andreas Klinger wrote:
>>> +  - |
>>> +    i2c {
>>> +        #address-cells = <1>;
>>> +        #size-cells = <0>;
>>> +
>>> +        color-sensor@29 {
>>> +            compatible = "vishay,veml6046x00";
>>> +            reg = <0x29>;
>>> +            vdd-supply = <&vdd_reg>;
>>> +            interrupt-parent = <&gpio2>;
>>> +            interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
>> Need an include for this I think.  Make sure to test build your
>> bindings following the instructions in the bot message.
> 
> I already sent out an version 2 yesterday which is with the include, tested and
> already reviewed by Krzysztof.

The point is that you should test it, not rely on us and our tools (e.g.
my or Rob's machine). If our tools report such issues, it is already too
late because it means you did not follow the process.

Best regards,
Krzysztof




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux