> > + compatible: > > + enum: > > + - adi,ad4050 > > + - adi,ad4052 > > + - adi,ad4056 > > + - adi,ad4058 > > Can you mention in your commit message what differs between these > devices that makes picking one as the "base"/fallback compatible > unsuitable please? Sure, to be added: Each variant of the family differs in speed and resolution, resulting in different scan types and spi word sizes, that are matched by the compatible with the chip_info. The device contains two required interrupts (gp0, gp1) and one optional gpio (cnv). > > + > > + vdd-supply: true > > + vdd_1_8-supply: true > > You're allowed to use . in property names, and the _s should be -s. > That said, vdd and vdd 1.8? Shouldn't both have the voltage in them in > that case? I overlooked the supplies, the correct are vdd, vio as mandatory, and vref is optional. Jorge
