> > drivers/staging/iio/addac/adt7316* > The device can communicate through I2C or SPI so could use regmap API to > standardize data transfers in the driver. > There was an old patch updating to regmap > https://marc.info/?l=linux-iio&m=154853847705361&w=2. > Aside from I2C related changes by and minor clean up changes, this driver hasn't > got updates in a while. > Suggested improvements: > - Use regmap to standardize data transfers. > - Add devicetree documentation. > - Check/change if attributes can use standard ABI and document those that are specific. This one is an interesting part - I have one somewhere from trying to help on the previous go at cleaning it up. One issue is that I couldn't manage to get a stable SPI connection patched onto the dev board. It kind of worked if I used a long cable and did a rain dance, but not enough to really test it. Jonathan