On Mon, Mar 03, 2025 at 06:22:46PM +0530, Saalim Quadri wrote: > Reported by checkpatch: > > CHECK: Avoid CamelCase > > Signed-off-by: Saalim Quadri <danascape@xxxxxxxxx> > --- > drivers/staging/iio/impedance-analyzer/ad5933.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c > index d5544fc2fe98..a1a5eee4f736 100644 > --- a/drivers/staging/iio/impedance-analyzer/ad5933.c > +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c > @@ -43,10 +43,10 @@ > #define AD5933_CTRL_POWER_DOWN (0xA << 4) > #define AD5933_CTRL_STANDBY (0xB << 4) > > -#define AD5933_CTRL_RANGE_2000mVpp (0x0 << 1) > -#define AD5933_CTRL_RANGE_200mVpp (0x1 << 1) > -#define AD5933_CTRL_RANGE_400mVpp (0x2 << 1) > -#define AD5933_CTRL_RANGE_1000mVpp (0x3 << 1) > +#define AD5933_CTRL_RANGE_2000MVPP (0x0 << 1) > +#define AD5933_CTRL_RANGE_200MVPP (0x1 << 1) > +#define AD5933_CTRL_RANGE_400MVPP (0x2 << 1) > +#define AD5933_CTRL_RANGE_1000MVPP (0x3 << 1) No, these are units of measurement, the "m" is correct here, right? If you change that to "M" it logically means something a lot different :( Please always treat checkpatch.pl as a hint, not as a rule. thanks, greg k-h
