On Mon, 2025-02-17 at 14:16 +0000, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
>
> These new functions allow sparse to find failures to release
> direct mode reducing chances of bugs over the claim_direct_mode()
> functions that are deprecated.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> ---
Reviewed-by: Nuno Sá <nuno.sa@xxxxxxxxxx>
> drivers/iio/adc/ad4030.c | 21 +++++++++------------
> 1 file changed, 9 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/iio/adc/ad4030.c b/drivers/iio/adc/ad4030.c
> index ab5497c8ea1e..209cfc2e1785 100644
> --- a/drivers/iio/adc/ad4030.c
> +++ b/drivers/iio/adc/ad4030.c
> @@ -784,13 +784,12 @@ static int ad4030_read_raw(struct iio_dev *indio_dev,
> if (info == IIO_CHAN_INFO_SCALE)
> return ad4030_get_chan_scale(indio_dev, chan, val, val2);
>
> - ret = iio_device_claim_direct_mode(indio_dev);
> - if (ret)
> - return ret;
> + if (!iio_device_claim_direct(indio_dev))
> + return -EBUSY;
>
> ret = ad4030_read_raw_dispatch(indio_dev, chan, val, val2, info);
>
> - iio_device_release_direct_mode(indio_dev);
> + iio_device_release_direct(indio_dev);
>
> return ret;
> }
> @@ -822,13 +821,12 @@ static int ad4030_write_raw(struct iio_dev *indio_dev,
> {
> int ret;
>
> - ret = iio_device_claim_direct_mode(indio_dev);
> - if (ret)
> - return ret;
> + if (!iio_device_claim_direct(indio_dev))
> + return -EBUSY;
>
> ret = ad4030_write_raw_dispatch(indio_dev, chan, val, val2, info);
>
> - iio_device_release_direct_mode(indio_dev);
> + iio_device_release_direct(indio_dev);
>
> return ret;
> }
> @@ -839,16 +837,15 @@ static int ad4030_reg_access(struct iio_dev *indio_dev,
> unsigned int reg,
> const struct ad4030_state *st = iio_priv(indio_dev);
> int ret;
>
> - ret = iio_device_claim_direct_mode(indio_dev);
> - if (ret)
> - return ret;
> + if (!iio_device_claim_direct(indio_dev))
> + return -EBUSY;
>
> if (readval)
> ret = regmap_read(st->regmap, reg, readval);
> else
> ret = regmap_write(st->regmap, reg, writeval);
>
> - iio_device_release_direct_mode(indio_dev);
> + iio_device_release_direct(indio_dev);
>
> return ret;
> }
