On Sun, 2025-02-09 at 18:06 +0000, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
>
> This complex cleanup.h use case of conditional guards has proved
> to be more trouble that it is worth in terms of false positive compiler
> warnings and hard to read code.
>
> Move directly to the new claim/release_direct() that allow sparse
> to check for unbalanced context.
>
> Cc: Angelo Dureghello <adureghello@xxxxxxxxxxxx>
> Reviewed-by: David Lechner <dlechner@xxxxxxxxxxxx>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> ---
Reviewed-by: Nuno Sa <nuno.sa@xxxxxxxxxx>
> drivers/iio/dac/ad3552r-hs.c | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/iio/dac/ad3552r-hs.c b/drivers/iio/dac/ad3552r-hs.c
> index c1dae58c1975..cd8dabb60c55 100644
> --- a/drivers/iio/dac/ad3552r-hs.c
> +++ b/drivers/iio/dac/ad3552r-hs.c
> @@ -129,16 +129,19 @@ static int ad3552r_hs_write_raw(struct iio_dev
> *indio_dev,
> int val, int val2, long mask)
> {
> struct ad3552r_hs_state *st = iio_priv(indio_dev);
> + int ret;
>
> switch (mask) {
> case IIO_CHAN_INFO_RAW:
> + if (!iio_device_claim_direct(indio_dev))
> + return -EBUSY;
> /* For RAW accesses, stay always in simple-spi. */
> - iio_device_claim_direct_scoped(return -EBUSY, indio_dev) {
> - return st->data->bus_reg_write(st->back,
> - AD3552R_REG_ADDR_CH_DAC_16B(chan-
> >channel),
> - val, 2);
> - }
> - unreachable();
> + ret = st->data->bus_reg_write(st->back,
> + AD3552R_REG_ADDR_CH_DAC_16B(chan->channel),
> + val, 2);
> +
> + iio_device_release_direct(indio_dev);
> + return ret;
> default:
> return -EINVAL;
> }
