Hello Jonathan, On Sun, Feb 16, 2025 at 04:36:00PM +0000, Jonathan Cameron wrote: > On Wed, 12 Feb 2025 11:53:23 +0100 > Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx> wrote: > > > The function ad_sd_calibrate() enables the channel to calibrate at > > function entry but doesn't disable it on exit. This is problematic > > because if two (or more) channels are calibrated in a row, the second > > calibration isn't executed as intended as the first (still enabled) > > channel is recalibrated and after the first irq (i.e. when the > > calibration of the first channel completed) the calibration is aborted. > > > > To fix this, disable the calibrated channel after calibration. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx> > Whilst you said don't look in reply to patch 3 I ignored you. ;) > > This feels like it deserves a fixes tag. Maybe. The ad7124 driver currently doesn't use this function. And if the described behaviour isn't relevant for the other chips, that's fine. Needs some more research. Best regards Uwe
Attachment:
signature.asc
Description: PGP signature
