On Sat, Feb 08, 2025 at 03:07:08PM +0800, Hermes Zhang wrote: > Hi, > > On 2025/2/7 2:20, Conor Dooley wrote: > > diff --git a/Documentation/devicetree/bindings/iio/chemical/sensirion,senxx.yaml b/Documentation/devicetree/bindings/iio/chemical/sensirion,senxx.yaml > > new file mode 100644 > > index 000000000000..4d998eabe441 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/chemical/sensirion,senxx.yaml > > filename matching a compatible please. > So sensirion,sen66.yaml? > > + https://sensirion.com/media/documents/6791EFA0/62A1F68F/Sensirion_Datasheet_Environmental_Node_SEN5x.pdf > > + https://sensirion.com/media/documents/FAFC548D/6731FFFA/Sensirion_Datasheet_SEN6x.pdf > > + > > +properties: > > + compatible: > > + enum: > > + - sensirion,sen50 > > + - sensirion,sen54 > > + - sensirion,sen55 > > + - sensirion,sen60 > > + - sensirion,sen65 > > + - sensirion,sen66 > > I'd like a note in the commit message as to how all of these devices are > > different please. > Sure, will fix in v2. > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > +required: > > > + - compatible > > > + - reg > > No supplies needed for this device? Seems like you would need at least > > one, no? > > You mean the vdd-supply? The chip require a e.g. 3.3v VDD, but in our HW, we > have no gpio/regulator to control it, connect directly by the HW, should I > still need to have one vdd-supply here? Might not be controllable in your case, but if the device needs power from somewhere it should have one in the binding.
Attachment:
signature.asc
Description: PGP signature
