Hello Jonathan, On Sat, Feb 08, 2025 at 03:18:24PM +0000, Jonathan Cameron wrote: > On Tue, 4 Feb 2025 12:50:23 +0100 > Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx> wrote: > > > If one or more of the 16 channels are enabled and the driver is not > > aware of that, unexpected things happen because different channels are > > used than intended. To prevent that, all channels should be disabled at > > probe time. In Commit 4be339af334c ("iio: adc: ad7124: Disable all > > channels at probe time") I intended do that, however only the channels > > that are potentially used by the driver and not all channels are > > disabled since then. So disable all 16 channels and not only the used > > ones. > > > > Also fix the same issue in the .disable_all() callback. > > > > Fixes: 4be339af334c ("iio: adc: ad7124: Disable all channels at probe time") > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx> > > I've applied this on the togreg branch of iio.git but you may need > to do a manual backport of the fix to get it on 6.14 once that's > released. hmm, $ git fetch git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg From https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio * branch togreg -> FETCH_HEAD $ git log --oneline v6.14-rc1..FETCH_HEAD -- drivers/iio/adc/ad7124.c cf67879bd428 iio: adc: ad7124: Micro-optimize channel disabling the commit is not there. Did I understand something wrong? Best regards Uwe
Attachment:
signature.asc
Description: PGP signature