On Mon, Feb 03, 2025 at 11:54:42AM +0200, Andy Shevchenko wrote: > On Mon, Feb 03, 2025 at 01:38:56PM +0530, Raag Jadav wrote: > > Convert to use devm_kmemdup_array() which is more robust. > > ... > > > - channels = devm_kmemdup(dev, channel_templates, > > - sizeof(channels[0]) * max_channels, GFP_KERNEL); > > + channels = devm_kmemdup_array(dev, channel_templates, max_channels, > > + sizeof(channels[0]), GFP_KERNEL); > > I would use more regular sizeof(*channels) This might get confusing since we're assigning it back to channels. Raag
