On Thu, 16 Jan 2025 19:03:41 +0100 Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx> wrote: > The key objective in ad7124_disable_one() is clearing the > AD7124_CHANNEL_EN_MSK bit in the channel register. However there is no > advantage to keep the other bits in that register because when the > channel is used next time, all fields are rewritten anyhow. So instead > of using ad7124_spi_write_mask() (which is a register read plus a > register write) use a simple register write clearing the complete > register. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx> Hi Uwe, This change looks fine but why not the same in ad7124_disable_all()?