On Fri, 2025-01-10 at 11:24 +0100, Angelo Dureghello wrote: > From: Angelo Dureghello <adureghello@xxxxxxxxxxxx> > > Set a better info message on wrong chip id, fixing the > expected value as read from the info struct. > > Signed-off-by: Angelo Dureghello <adureghello@xxxxxxxxxxxx> > --- > drivers/iio/dac/ad3552r-hs.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/dac/ad3552r-hs.c b/drivers/iio/dac/ad3552r-hs.c > index 8974df625670..27949f207d42 100644 > --- a/drivers/iio/dac/ad3552r-hs.c > +++ b/drivers/iio/dac/ad3552r-hs.c > @@ -326,8 +326,9 @@ static int ad3552r_hs_setup(struct ad3552r_hs_state *st) > > id |= val << 8; > if (id != st->model_data->chip_id) > - dev_info(st->dev, "Chip ID error. Expected 0x%x, Read > 0x%x\n", > - AD3552R_ID, id); > + dev_info(st->dev, > + "Chip ID mismatch, detected 0x%x but expected > 0x%x\n", > + id, st->model_data->chip_id); Since you're doing this, I would prefer dev_warn() over dev_info() - Nuno Sá > > /* Clear reset error flag, see ad3552r manual, rev B table 38. */ > ret = st->data->bus_reg_write(st->back, AD3552R_REG_ADDR_ERR_STATUS, >
