Sat, Jan 04, 2025 at 01:11:32PM +0000, Jonathan Cameron kirjoitti:
> On Mon, 30 Dec 2024 10:15:21 -0500
> Trevor Gamblin <tgamblin@xxxxxxxxxxxx> wrote:
> > On 2024-12-30 10:10, Uwe Kleine-König wrote:
> > > Error messages passed to dev_err_probe() are supposed to end in "\n".
> > > Fix accordingly.
> > >
> > > Fixes: b7ffd0fa65e9 ("iio: adc: ad7625: add driver")
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx>
> > Tested-by: Trevor Gamblin <tgamblin@xxxxxxxxxxxx>
Actually Q to everybody: do you know that "supposed" in this commit message is
just a good style as dev_*() are all automatically add newline AFAICS?
P.S. Recently discussed this topic with Linus W. and if I'm not mistaken one
should never see an issue with those messages in the dmesg. OTOH, all other
means that try to save or do anything with messages w/o \n should be aware.
--
With Best Regards,
Andy Shevchenko
