On Wed, 8 Jan 2025 14:43:22 -0600 David Lechner <dlechner@xxxxxxxxxxxx> wrote: > On 1/8/25 11:29 AM, Angelo Dureghello wrote: > > From: Angelo Dureghello <adureghello@xxxxxxxxxxxx> > > > > Fix ad3541/2r voltage ranges to be as per ad3542r datasheet, > > rev. C, table 38 (page 57). > > > > The wrong ad354xr ranges was generating erroneous Vpp output. > > > > In more details: > > - fix wrong number of ranges, they are 5 ranges, not 6, > > - remove non-existent 0-3V range, > > - adjust order, since ad3552r_find_range() get a wrong index, > > producing a wrong Vpp as output. > > > > Retested all the ranges on real hardware, EVALAD3542RFMCZ: > > > > adi,output-range-microvolt (fdt): > > <(000000) (2500000)>; ok (Rfbx1, switch 10) > > <(000000) (5000000)>; ok (Rfbx1, switch 10) > > <(000000) (10000000)>; ok (Rfbx1, switch 10) > > <(-5000000) (5000000)>; ok (Rfbx2, switch +/- 5) > > <(-2500000) (7500000)>; ok (Rfbx2, switch -2.5/7.5) > > > > Fixes: 8f2b54824b28 ("drivers:iio:dac: Add AD3552R driver support") > > Signed-off-by: Angelo Dureghello <adureghello@xxxxxxxxxxxx> > > --- > Reviewed-by: David Lechner <dlechner@xxxxxxxxxxxx> > Applied to the fixes-togreg branch of iio.git and marked for stable. Thanks, Jonathan