On 01/05, Jonathan Cameron wrote: > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > This complex cleanup.h use case of conditional guards has proved > to be more trouble that it is worth in terms of false positive compiler > warnings and hard to read code. > > Move directly to the new claim/release_direct() that allow sparse > to check for unbalanced context. > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > --- > drivers/iio/adc/ad4000.c | 61 +++++++++++++++++++++++++--------------- > 1 file changed, 38 insertions(+), 23 deletions(-) > Hi Jonathan, aside from the spurious blank line noted by David, the changes for ad4000 look good to me. Acked-by: <marcelo.schmitt1@xxxxxxxxx> I also tried running Sparse on IIO subsystem but didn't see any warns for the drivers being changed (nor prior nor after applying the patches). make CHECK="path_to_local_sparse_v0.6.4-66-g0196afe1" C=2 drivers/iio/ Did see warns after adding incorrect type in assignments in the driver. Mind sharing how you are running Sparse? Thanks, Marcelo