On Tue, 24 Dec 2024 11:59:03 +0100 Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> wrote: > The current scale is not ABI-compliant as it is just the sensor gain > instead of the value that acts as a multiplier to be applied to the raw > value (there is no offset). > > Use the iio-gts helpers to obtain the proper scale values according to > the gain and integration time to match the resolution tables from the > datasheet. When at it, use 'scale' instead of 'gain' consistently for > the get/set functions to avoid misunderstandings. > > Fixes: c5a23f80c164 ("iio: light: add support for veml3235") > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> Hi Javier, To me this looks fine, but I'd like Matti to take another quick look at this and patch 1 if time allows given Matti is a lot more familiar with the GTS helpers than I am. Jonathan