On Wed, 25 Dec 2024 18:13:38 +0000 Lothar Rubusch <l.rubusch@xxxxxxxxx> wrote: > Having interrupts events and FIFO available allows to evaluate the > sensor events. Cover the list of interrupt based sensor events. Keep > them in the header file for readability. > > Signed-off-by: Lothar Rubusch <l.rubusch@xxxxxxxxx> One comment inline Thanks, Jonathan > #define ADXL345_REG_BW_RATE 0x2C > #define ADXL345_REG_POWER_CTL 0x2D > #define ADXL345_REG_INT_ENABLE 0x2E > @@ -34,20 +59,40 @@ > #define ADXL345_FIFO_CTL_MODE(x) FIELD_PREP(GENMASK(7, 6), x) > > #define ADXL345_INT_DATA_READY BIT(7) > +#define ADXL345_INT_SINGLE_TAP BIT(6) > +#define ADXL345_INT_DOUBLE_TAP BIT(5) > +#define ADXL345_INT_ACTIVITY BIT(4) > +#define ADXL345_INT_INACTIVITY BIT(3) > +#define ADXL345_INT_FREE_FALL BIT(2) > #define ADXL345_INT_WATERMARK BIT(1) > #define ADXL345_INT_OVERRUN BIT(0) > + > +#define ADXL345_S_TAP_MSK ADXL345_INT_SINGLE_TAP > +#define ADXL345_D_TAP_MSK ADXL345_INT_DOUBLE_TAP Why have these?