On Sat, Dec 21, 2024 at 05:56:01PM +0200, Alisa-Dariana Roman wrote:
> AD7191 is a pin-programmable, ultralow noise 24-bit sigma-delta ADC
> designed for precision bridge sensor measurements. It features two
> differential analog input channels, selectable output rates,
> programmable gain, internal temperature sensor and simultaneous
> 50Hz/60Hz rejection.
>
> Signed-off-by: Alisa-Dariana Roman <alisa.roman@xxxxxxxxxx>
Sob mismatch.
Please run scripts/checkpatch.pl and fix reported warnings. After that,
run also 'scripts/checkpatch.pl --strict' and (probably) fix more
warnings. Some warnings can be ignored, especially from --strict run,
but the code here looks like it needs a fix. Feel free to get in touch
if the warning is not clear.
> + odr1-gpios:
> + description: GPIO connected to ODR1 pin for output data rate selection
a/GPIO connected to//
That's just obvious, cannot be "SPI MOSI line connected to ODR1 pin",
right? Samee in all other places.
> + maxItems: 1
> +
> + odr2-gpios:
> + description: GPIO connected to ODR2 pin for output data rate selection
> + maxItems: 1
> +
> + pga1-gpios:
> + description: GPIO connected to PGA1 pin for gain selection
> + maxItems: 1
> +
> + pga2-gpios:
> + description: GPIO connected to PGA2 pin for gain selection
> + maxItems: 1
> +
> + temp-gpios:
> + description: GPIO connected to TEMP pin for temperature sensor enable
> + maxItems: 1
> +
> + chan-gpios:
> + description: GPIO connected to CHAN pin for input channel selection
> + maxItems: 1
> +
> + clksel-gpios:
> + description: GPIO connected to CLKSEL pin for clock source selection
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - avdd-supply
> + - dvdd-supply
> + - vref-supply
> + - spi-cpol
> + - spi-cpha
> + - odr1-gpios
> + - odr2-gpios
> + - pga1-gpios
> + - pga2-gpios
> + - temp-gpios
> + - chan-gpios
> + - clksel-gpios
> +
> +allOf:
> + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + spi0 {
spi
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + adc@0 {
> + compatible = "adi,ad7191";
Best regards,
Krzysztof
