On Tue, Dec 24, 2024 at 11:43:16AM +0530, Hardevsinh Palaniya wrote: > Add Support for OPT3004 Digital ambient light sensor (ALS) with > increased angular IR rejection Missing period here. > The OPT3004 sensor shares the same functionality and scale range as > the OPT3001. This Adds the compatible string for OPT3004, enabling > the driver to support it without any functional changes. > > Datasheet: https://www.ti.com/lit/gpn/opt3004 > This blank line is not needed. > Tested-by: Hardevsinh Palaniya <hardevsinh.palaniya@xxxxxxxxxxxxxxxxx> This tag is superfluous, it's assumed that author testing their code. > Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@xxxxxxxxxxxxxxxxx> ... > help > If you say Y or M here, you get support for Texas Instruments > - OPT3001 Ambient Light Sensor, OPT3002 Light-to-Digital Sensor. > + OPT3001 Ambient Light Sensor, OPT3002 Light-to-Digital Sensor, > + OPT3004 Digital ambient light sensor. Can you rather convert this to a list (one item per line)? - OPT3001 Ambient Light Sensor - OPT3002 Light-to-Digital Sensor - OPT3004 Digital ambient light sensor ... > static const struct of_device_id opt3001_of_match[] = { > { .compatible = "ti,opt3001", .data = &opt3001_chip_information }, > { .compatible = "ti,opt3002", .data = &opt3002_chip_information }, > + { .compatible = "ti,opt3004", .data = &opt3001_chip_information }, > { } > }; I'm always puzzled why do we need a new compatible for the existing driver data? Is this hardware has an additional feature that driver does not (yet) implement? -- With Best Regards, Andy Shevchenko
