On Wed, 18 Dec 2024 13:48:04 -0600 Rob Herring <robh@xxxxxxxxxx> wrote: > On Wed, Dec 18, 2024 at 11:37:42AM -0300, Marcelo Schmitt wrote: > > Add device tree documentation for AD4170 sigma-delta ADCs. > > > > The usual question with long lists of properties. Any of these should be > run-time controlled (by userspace) instead? If they might vary by the > user for given h/w design, then should be user controlled instead. Hi Rob, I took a look and mostly make sense in DT as they are hardware design things as it's all about driving an external bridge circuit for which there will be a correct configuration. There were a few exceptions however hiding in amongst them! ADCs that support Wheatstone bridge operations are probably my least favourite drivers to review. Very very fiddly as they have complex (and random seeming) control functions for circuitry that is off chip and only somewhat standard. Jonathan
