On Wed, Dec 18, 2024 at 11:37:26AM -0300, Marcelo Schmitt wrote: > From: Ana-Maria Cusco <ana-maria.cusco@xxxxxxxxxx> > > Add defines to improve readability of AD4170 device tree nodes. Binding headers define the ABI between driver and DTS. Improving readability of DTS is not their purpose. Explain why this is binding. Also, I don't get why this is separate from device binding - see git log history how various IDs are being added. > > Signed-off-by: Ana-Maria Cusco <ana-maria.cusco@xxxxxxxxxx> > Co-developed-by: Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx> > Signed-off-by: Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx> > --- > include/dt-bindings/iio/adc/adi,ad4170.h | 96 ++++++++++++++++++++++++ > 1 file changed, 96 insertions(+) > create mode 100644 include/dt-bindings/iio/adc/adi,ad4170.h > > diff --git a/include/dt-bindings/iio/adc/adi,ad4170.h b/include/dt-bindings/iio/adc/adi,ad4170.h > new file mode 100644 > index 000000000000..a508b37e9a46 > --- /dev/null > +++ b/include/dt-bindings/iio/adc/adi,ad4170.h > @@ -0,0 +1,96 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > +/* > + * AD4170 ADC > + * > + * Copyright 2024 Analog Devices Inc. > + * > + * Licensed under the GPL-2. No, you cannot say something else than SPDX. Anyway, drop license boilerplate text. > + */ > + > +#ifndef _DT_BINDINGS_IIO_ADC_AD4170_H_ > +#define _DT_BINDINGS_IIO_ADC_AD4170_H_ > + Best regards, Krzysztof
