On Fri, 13 Dec 2024 21:19:05 +0000 Lothar Rubusch <l.rubusch@xxxxxxxxx> wrote: > Add interrupt-names INT1 and INT2 for the two interrupt lines of the > sensor. > > When one of the two interrupt lines is connected, the interrupt as its > interrupt-name, need to be declared in the devicetree. The driver then > configures the sensor to indicate its events on either INT1 or INT2. > > If no interrupt is configured, then no interrupt-name should be > configured, and vice versa. In this case the sensor runs in FIFO BYPASS > mode. This allows sensor measurements, but none of the sensor events. > > Signed-off-by: Lothar Rubusch <l.rubusch@xxxxxxxxx> Just to repeat what I sent in reply to v6 (well after you'd posted this). Maybe we can maintain compatibility with the binding before this by adding a default of INT1. Then you'd need to drop the dependency on interrupt-names. I'm not sure though if the checking of number of entries will work against a default. Give it a go and see what happens :) We are lucky that we can't have bindings in the wild assuming ordering of the two interrupts due to the maxItems being set for interrupts. It's a messy corner, perhaps we should just not bother in the binding, but keep that default handling in the driver? DT binding folk, what do you think the best way of handling this is? Jonathan > --- > .../devicetree/bindings/iio/accel/adi,adxl345.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml > index bc46ed00f..4f971035b 100644 > --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml > +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml > @@ -37,6 +37,14 @@ properties: > interrupts: > maxItems: 1 That is not going to work if we have two interrupts specified. It does at least mean we only need > > + interrupt-names: > + items: > + - enum: [INT1, INT2] > + > +dependencies: > + interrupts: [ 'interrupt-names' ] > + interrupt-names: [ 'interrupts' ] > + > required: > - compatible > - reg > @@ -60,6 +68,7 @@ examples: > reg = <0x2a>; > interrupt-parent = <&gpio0>; > interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "INT1"; > }; > }; > - | > @@ -78,5 +87,6 @@ examples: > spi-cpha; > interrupt-parent = <&gpio0>; > interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "INT2"; > }; > };
