On Wed, Dec 11, 2024 at 06:29:58PM +0000, Jonathan Cameron wrote: > On Mon, 9 Dec 2024 02:45:46 +0200 > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Sun, Dec 08, 2024 at 05:10:01PM +0000, Jonathan Cameron wrote: > > > On Tue, 3 Dec 2024 21:48:51 +0200 > > > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > > > > > device.h is a huge header which is hard to follow and easy to miss > > > > something. Improve that by splitting devres APIs to device/devres.h. > > > > > > > > In particular this helps to speedup the build of the code that includes > > > > device.h solely for a devres APIs. ... > > > > -#include <linux/overflow.h> > > > > + > > > Unrelated change. > > > > Which one? Blank line? > I think that's what I meant :) Was a trivial comment though. Got it! ... > > > > -#include <linux/cleanup.h> > > > This header movement is unrelated. > > > > No problem to let it stay at the same place. > > > > > I agree both are good but probably want to be a separate patch. > > > > > > Otherwise this seems sensible to me, but your cc list seems a little short! > > > > > > Greg and Rafael seems a good starting point so I've added them. > > > > Thanks! I need to check why they were not included into the original > > submission. Perhpas I need to amend MAINTAINERS, I added the file to MAINTAINERS locally. -- With Best Regards, Andy Shevchenko
