Re: [PATCH v6 2/7] iio: accel: adxl345: complete the list of defines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 11, 2024 at 11:06:43PM +0000, Lothar Rubusch wrote:
> Extend the list of constants. Keep them the header file for readability.
> The defines allow the implementation of events like watermark, single
> tap, double tap, freefall, etc.

We don't store constants just to store constants, so this commit does
not have reason to be separate. We store constants/defines only to
implement the driver. Merge these with the users... unless you want to
say there are no users of this at all, but then make it clear: move the
patch to the end.

Best regards,
Krzysztof





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux